Revert "Add support for submessages in template - part1. "#1707
Merged
sebastienvas merged 1 commit intomasterfrom Nov 14, 2017
Merged
Revert "Add support for submessages in template - part1. "#1707sebastienvas merged 1 commit intomasterfrom
sebastienvas merged 1 commit intomasterfrom
Conversation
This reverts commit c349b99.
sebastienvas
approved these changes
Nov 14, 2017
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebastienvas Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1617
The presubmit didn't pass on that PR.
This blocks all presubmit, presubmit stuck during bazel_to_go : https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/1652/istio-presubmit/5/
https://prow.istio.io/?job=istio-presubmit