Revert "Lock down development of installer (#13350)"#14230
Revert "Lock down development of installer (#13350)"#14230istio-testing merged 2 commits intoistio:masterfrom
Conversation
install/OWNERS
Outdated
There was a problem hiding this comment.
I think the list is a bit too large here. Can you select from the people who contributed recently and are active - and keep it to 4-5 ?
install/kubernetes/helm/README.md
Outdated
There was a problem hiding this comment.
How about: 'new or risky features should go to istio/installer - only critical bugfixes in here'.
costinm
left a comment
There was a problem hiding this comment.
My understanding is that the agreement in ToC was that we'll ship the old installer as default because it is stable and due to the deprecation policy - but we still plan to deprecated it and switch to new installer in 1.3.
|
@costinm good points, I updated the readme to point to istio/installer For the owners, I don't know if we have a standard criteria but I ran |
|
/test istio-pilot-multicluster-e2e-master /test integ-pilot-k8s-presubmit-tests-master |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: costinm, howardjohn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-simpleTests-master |
3 similar comments
|
/test e2e-simpleTests-master |
|
/test e2e-simpleTests-master |
|
/test e2e-simpleTests-master |
|
/test all |
This reverts commit a08b488.
25b7ac7 to
dc83226
Compare
|
New changes are detected. LGTM label has been removed. |
|
@howardjohn: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
lgtm was just removed to trigger tests again since prow was broken. Self adding to unblock this |
This reverts commit a08b488.
The TOC decided we will be using the existing installer as default for 1.2 still, so we need to undo this. This is especially important since we locked down the owners and both of them will be at kubecon/vacation