Skip to content

[Replaced by PR 13685] Disable SDS Vault integration test before Vault server is recovered#13675

Closed
lei-tang wants to merge 1 commit intoistio:masterfrom
lei-tang:disable-vault-integration-test
Closed

[Replaced by PR 13685] Disable SDS Vault integration test before Vault server is recovered#13675
lei-tang wants to merge 1 commit intoistio:masterfrom
lei-tang:disable-vault-integration-test

Conversation

@lei-tang
Copy link
Copy Markdown
Contributor

@lei-tang lei-tang commented Apr 27, 2019 •
edited
Loading

Tests under

  • security/pkg/nodeagent/caclient/providers/vault/
  • tests/integration/security/sds_vault_flow

fail because the cluster hosting the test Vault server was deleted.

This PR disables SDS Vault integration test before a new test Vault server is created.

Issue: #13674

Note: this PR has been replaced by #13685, which fixes the failed integration tests for SDS Vault flow.

@lei-tang lei-tang changed the title Disable SDS Vault integration test before Vault server is fixed Disable SDS Vault integration test before Vault server is recovered Apr 27, 2019
@lei-tang lei-tang mentioned this pull request Apr 27, 2019
Merged
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 27, 2019

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 45b7ada link /test istio-unit-tests
prow/istio-integ-k8s-tests.sh 45b7ada link /test istio-integ-k8s-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang
Copy link
Copy Markdown
Contributor Author

lei-tang commented Apr 28, 2019

This PR has been replaced by #13685, which fixes the failed integration tests for SDS Vault flow.

@lei-tang lei-tang changed the title Disable SDS Vault integration test before Vault server is recovered [Replaced by PR 13685] Disable SDS Vault integration test before Vault server is recovered Apr 28, 2019
nmittler
nmittler approved these changes Apr 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@nmittler nmittler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lei-tang, nmittler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Apr 29, 2019

This test still seems to be failing: TestClientOnExampleHttpVaultCA
https://circleci.com/gh/istio/istio/401035?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@lei-tang
Copy link
Copy Markdown
Contributor Author

lei-tang commented Apr 29, 2019

The failure is due to that this PR has not been rebased to the latest master yet. Close this PR as it has been replaced by PR 13685.

@lei-tang lei-tang closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

@ozevren ozevren Awaiting requested review from ozevren

+1 more reviewer

@nmittler nmittler nmittler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nmittler nmittler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lei-tang @istio-testing @ozevren @howardjohn @nmittler @googlebot