Skip to content

Cherry-pick failover nil pointer panic fix from #13252#13506

Merged
rshriram merged 1 commit intoistio:release-1.1from
liamawhite:failover-panic-fix
Apr 23, 2019
Merged

Cherry-pick failover nil pointer panic fix from #13252#13506
rshriram merged 1 commit intoistio:release-1.1from
liamawhite:failover-panic-fix

Conversation

@liamawhite
Copy link
Copy Markdown
Member

@liamawhite liamawhite commented Apr 22, 2019

Signed-off-by: Liam White liam@tetrate.io

cherry-pick failover nil pointer panic fix from #13252
159815c 
Signed-off-by: Liam White <liam@tetrate.io>
@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Apr 22, 2019

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 22, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: howardjohn, liamawhite
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram

If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 22, 2019

@liamawhite: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh 159815c link /test istio-integ-k8s-tests
prow/istio-pilot-multicluster-e2e.sh 159815c link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram rshriram merged commit 21891f9 into istio:release-1.1 Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rshriram rshriram Awaiting requested review from rshriram

@ZackButcher ZackButcher Awaiting requested review from ZackButcher

Assignees

@howardjohn howardjohn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liamawhite @howardjohn @istio-testing @googlebot @rshriram