Skip to content

Cherry pick #13409 into release-1.1#13505

Merged
rshriram merged 1 commit intoistio:release-1.1from
liamawhite:release-1.1
Apr 23, 2019
Merged

Cherry pick #13409 into release-1.1#13505
rshriram merged 1 commit intoistio:release-1.1from
liamawhite:release-1.1

Conversation

@liamawhite
Copy link
Copy Markdown
Member

@liamawhite liamawhite commented Apr 22, 2019

Fixes panic in pilot agent when provided with custom cert paths. (#13409)

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Apr 22, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Apr 22, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 22, 2019

@liamawhite: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh b380a95 link /test istio-integ-k8s-tests
prow/istio-pilot-multicluster-e2e.sh b380a95 link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn howardjohn added cla: yes and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Apr 22, 2019
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Apr 22, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Apr 23, 2019

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamawhite, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit 389d7d6 into istio:release-1.1 Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadimeisenbergibm vadimeisenbergibm Awaiting requested review from vadimeisenbergibm

@ymesika ymesika Awaiting requested review from ymesika

2 more reviewers

@vladlosev vladlosev vladlosev approved these changes

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rshriram rshriram

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liamawhite @googlebot @istio-testing @rshriram @vladlosev @howardjohn