[Kiali] [release-1.1] upgrade kiali#13312
Conversation
|
/assign @mandarjog @costinm @sdake Lin is on vacation - I'm hoping one of you folks will be able to do a quick review/merge to get this in the next istio release. |
…1823) * things needed for next version of kiali * additions needed for https://issues.jboss.org/browse/KIALI-2417 * install kiali v0.15 * add read-only role for people to use if they don't want to grant write access to kiali * mount secret to volume now, not env vars * add rbacconfigs - https://issues.jboss.org/browse/KIALI-2564 * add prometheus scrape annotations to scrape the new metrics endpoint * everything is now up to date for kiali v0.16 (cherry picked from commit eb2ca5b) # Conflicts: # install/kubernetes/helm/istio/charts/kiali/templates/deployment.yaml # install/kubernetes/helm/istio/charts/kiali/values.yaml
7d80db4 to
dc20f46
Compare
|
@jmazzitelli: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test istio_auth_sds_e2e |
sdake
left a comment
There was a problem hiding this comment.
/lgtm
/approve
The critical pod stuff - not sure why that is needed, but as this is a straight cherrypick, if that needs to be addressed, please submit a new PR to master and cherrypick it as well after it merges.
|
@duderino would you mind to merge this for release-1.1.4? |
I've no idea what that is :) That is outside of the work I've been doing. That was introduced in another PR unrelated to kiali specifically. See: #7312 We can remove it later, as you say, in case it really isn't needed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmazzitelli, linsun, sdake The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
merging to 1.1 as we need kiali to be on the new level to pass our security vulnerability scan. cc @johnma14 |
@mandarjog @costinm we need to get the 1.1 release upgraded with a newer Kiali. So this PR cherry picks #11823 to move up to v0.16.
I was going to move up to the latest with the Kiali Operator, but there is an issue with helm and deleting resources that are managed by operators (see that PR here if interested), so rather than wait for that issue to be fixed, I'm creating this PR here so we get an updated Kiali into the next 1.1 release ASAP so users of 1.1 don't have to do anything to get a later version of Kiali. @linsun I think is on vacation - I usually get her to help me move PRs along - so I may need some help to get this reviewed/approved/merged.