Skip to content

Add e2e tests for Authz v2 (#12271)#12814

Closed
pitlv2109 wants to merge 1 commit intoistio:masterfrom
pitlv2109:rbac-v2-e2e-tests
Closed

Add e2e tests for Authz v2 (#12271)#12814
pitlv2109 wants to merge 1 commit intoistio:masterfrom
pitlv2109:rbac-v2-e2e-tests

Conversation

@pitlv2109
Copy link
Copy Markdown
Member

Cherry-pick from #12271

Add e2e tests for additional fields in ServiceRole and ServiceRoleBinding.
Add e2e tests for workload selector.
Add e2e tests for new CRD AuthorizationPolicy.

For #12394

* WIP Authz v2 e2e tests

* Add e2e tests for authz v2
@istio-testing
Copy link
Copy Markdown
Collaborator

@pitlv2109: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh f9f51ab link /test istio-pilot-multicluster-e2e
prow/istio-integ-k8s-tests.sh f9f51ab link /test istio-integ-k8s-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@yangminzhu yangminzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@diemtvu diemtvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is ok. I just don't know should we enforce ourselves to have test in both e2e and integration folder or not.

Copy link
Copy Markdown
Contributor

@diemtvu diemtvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@diemtvu diemtvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: diemtvu, pitlv2109, yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pitlv2109
Copy link
Copy Markdown
Member Author

/cc @andraxylia @costinm @GregHanson @kyessenov @ijsnellf @nmittler @rshriram @vadimeisenbergibm @ZackButcher for owner approval.

This is the e2e test file for RBAC v2.

@nmittler
Copy link
Copy Markdown
Contributor

I know that this is a cherry-pick, but we should probably be using the new test framework for new tests.

@pitlv2109
Copy link
Copy Markdown
Member Author

Close this one and will create a new PR using the new testing framework + more tests.
/close

@istio-testing
Copy link
Copy Markdown
Collaborator

@pitlv2109: Closed this PR.

Details

In response to this:

Close this one and will create a new PR using the new testing framework + more tests.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants