Skip to content

Remove new labels, break helm template upgrade/downgrade#12240

Closed
costinm wants to merge 1 commit intoistio:release-1.1from
costinm:1.1-upgrade
Closed

Remove new labels, break helm template upgrade/downgrade#12240
costinm wants to merge 1 commit intoistio:release-1.1from
costinm:1.1-upgrade

Conversation

@costinm
Copy link
Copy Markdown
Contributor

@costinm costinm commented Mar 5, 2019

Adding labels make kubectl unhappy:

&{0xc4201143c0 0xc420396150 istio-system istio-galley /workspace/istio-master/go/src/github.com/costinm/istio-install/test/istio-system-1.0.6.yaml 0xc42000c520 98311441 false}
for: "/workspace/istio-master/go/src/github.com/costinm/istio-install/test/istio-system-1.0.6.yaml": Deployment.apps "istio-galley" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"istio":"galley"}: `selector` does not match template `labels`
Error from server (Invalid): error when applying patch:

@costinm costinm requested a review from sdake March 5, 2019 00:34
@istio-testing istio-testing requested review from linsun and ozevren March 5, 2019 00:34
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: costinm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@costinm costinm requested review from duderino and removed request for linsun and ozevren March 5, 2019 00:34
@duderino
Copy link
Copy Markdown

duderino commented Mar 5, 2019

/hold costin says he'll take another pass at this

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 5, 2019

@costinm: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests-minProfile.sh 7589e3a link /test e2e-simpleTestsMinProfile
prow/e2e-dashboard.sh 7589e3a link /test e2e-dashboard
prow/e2e-bookInfoTests-v1alpha3.sh 7589e3a link /test e2e-bookInfoTests-envoyv2-v1alpha3
prow/e2e-simpleTests-cni.sh 7589e3a link /test e2e-simpleTests-cni
prow/e2e-mixer-no_auth.sh 7589e3a link /test e2e-mixer-no_auth
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh 7589e3a link /test istio-pilot-e2e-envoyv2-v1alpha3
prow/e2e_pilotv2_auth_sds.sh 7589e3a link /test istio_auth_sds_e2e
prow/e2e-simpleTests.sh 7589e3a link /test e2e-simpleTests
prow/istio-pilot-multicluster-e2e.sh 7589e3a link /test istio-pilot-multicluster-e2e
prow/istio-integ-k8s-tests.sh 7589e3a link /test istio-integ-k8s-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm costinm closed this Mar 5, 2019
@sdake sdake mentioned this pull request Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdake sdake Awaiting requested review from sdake

@duderino duderino Awaiting requested review from duderino

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@costinm @istio-testing @duderino @googlebot