Skip to content

Fixing an EDS racetest#12150

Closed
ymesika wants to merge 1 commit intoistio:release-1.1from
ymesika:racetestFix
Closed

Fixing an EDS racetest#12150
ymesika wants to merge 1 commit intoistio:release-1.1from
ymesika:racetestFix

Conversation

@ymesika
Copy link
Copy Markdown
Member

@ymesika ymesika commented Feb 28, 2019

#11981 introduced a new racetest in TestEDS (see https://prow.k8s.io/view/gcs/istio-circleci/racetest/341195) as it modified the CLA while other goroutine was reading it.

/assign @hzxuzhonghu

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ymesika

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Feb 28, 2019

This is not that simple, @liamawhite #11981 is not right. For different proxies, pushEds concurrently, the ClusterLoadAssignment modification may influence each other. That is why I implement a shallow copy in https://github.com/istio/istio/pull/11256/files#diff-6713acfe7b9e389e7dcd429d08bee859R260

/cc @rshriram

@ymesika
Copy link
Copy Markdown
Member Author

ymesika commented Feb 28, 2019

@hzxuzhonghu We can make a CLA copy that ApplyLocalityLBSetting will be modifying.
Similar to the MeshNetworks filter.
WDYT?

@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Feb 28, 2019

Sure, restore the implement in #11256

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 28, 2019

@ymesika: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests-cni.sh fa299b7 link /test e2e-simpleTests-cni
prow/istio-integ-k8s-tests.sh fa299b7 link /test istio-integ-k8s-tests
prow/istio-pilot-multicluster-e2e.sh fa299b7 link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liamawhite liamawhite mentioned this pull request Feb 28, 2019
Merged
@ymesika
Copy link
Copy Markdown
Member Author

ymesika commented Feb 28, 2019

Fixed by #12151

@ymesika ymesika closed this Feb 28, 2019
@ymesika ymesika deleted the racetestFix branch February 28, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@rshriram rshriram Awaiting requested review from rshriram

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ymesika @istio-testing @hzxuzhonghu @googlebot