Skip to content

Istio auth sds e2e (#12100)#12130

Merged
istio-testing merged 5 commits intoistio:masterfrom
JimmyCYJ:istio_auth_sds_e2e
Feb 28, 2019
Merged

Istio auth sds e2e (#12100)#12130
istio-testing merged 5 commits intoistio:masterfrom
JimmyCYJ:istio_auth_sds_e2e

Conversation

@JimmyCYJ
Copy link
Copy Markdown
Member

@JimmyCYJ JimmyCYJ commented Feb 27, 2019

cherry-pick #12100 into master branch that fixes istio_auth_sds_e2e

@JimmyCYJ
Istio auth sds e2e (istio#12100)
9a2d9dc 
* use CredentialName for SIMPLE

* cvc

* rootca

* update test.

* update test

* fix format

* update gateway config

* fix test

* fix lint

* fix test

* add comments.

* add nolint

* update cvc

* update

* update

* update

* update

* update

* update

* format

* dep ensure --update istio.io/api

* Revise per comments

* Revise

* lint

* Marshal SDS call credential config using deterministic order

* update

* update

* revise

* add comment

* update

* Update validation

* fix istio_auth_sds_e2e

* fix TestRouteSNIViaEgressGateway/*
@JimmyCYJ JimmyCYJ closed this Feb 27, 2019
@JimmyCYJ JimmyCYJ reopened this Feb 28, 2019
@quanjielin
Copy link
Copy Markdown
Contributor

quanjielin commented Feb 28, 2019 •
edited
Loading

seems only coredump is failing now, see 17f6843 as reference

quanjielin
quanjielin approved these changes Feb 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@quanjielin quanjielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks Jimmy!

wattli
wattli approved these changes Feb 28, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@wattli wattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 28, 2019

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-simpleTests-cni.sh 7b7cedc link /test e2e-simpleTests-cni
prow/istio-integ-k8s-tests.sh 7b7cedc link /test istio-integ-k8s-tests
prow/istio-pilot-multicluster-e2e.sh 7b7cedc link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wenchenglu
Copy link
Copy Markdown
Contributor

wenchenglu commented Feb 28, 2019

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: JimmyCYJ, quanjielin, wattli, wenchenglu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit f03a6ca into istio:master Feb 28, 2019
@JimmyCYJ JimmyCYJ deleted the istio_auth_sds_e2e branch February 28, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@wattli wattli wattli approved these changes

@quanjielin quanjielin quanjielin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wenchenglu wenchenglu

@wattli wattli

@quanjielin quanjielin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JimmyCYJ @quanjielin @istio-testing @wenchenglu @wattli @googlebot