Conversation
|
Hi @chrisob. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @morvencao |
sdake
left a comment
There was a problem hiding this comment.
Nice contribution!
While you are in there can you change rbac to v1? Kubernetes has long been out of beta for rbac.
Cheers
-steve
|
/ok-to-test |
|
@sdake Glad to help, RBAC apiVersions updated to v1. Just wondering, these failed CI tests aren't due to my changes, right? 🤔 |
|
@chrisob tewst-integatoin-kubernetes, istio-integ-k8s-tets.sh and istio-pilot-multicluster-e2e.sh are busted. as for pilot-auth-v1alph3-v2 - unknown if this is because of your PR or not. I have not seen this gate failure signature prior, but that doesn't mean it doesn't exist :) I have rerun the workflow. |
| resources: ["configmaps", "endpoints", "pods", "services", "namespaces", "secrets", "replicationcontrollers"] | ||
| verbs: ["get", "list", "watch"] | ||
| - apiGroups: ["extensions"] | ||
| resources: ["replicasets"] |
There was a problem hiding this comment.
@sdake
Both the extensions and apps apiGroups contain a replicasets resource, so I merged this rule with the one below it (see - apiGroups: ["extensions", "apps"]).
|
if the PR fails to pass Cheers |
|
@morvencao look okay to you? |
|
/LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisob, morvencao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@chrisob: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Master branch changes related to #11234.
What started as a bug fix ended up as a general cleanup of Helm
ClusterRolerules (biggest cleanup is in Kiali's chart).