Skip to content

Cherry Pick: Only add localhost IP if no other IP address were found (#11367)#11370

Merged
istio-testing merged 1 commit intoistio:masterfrom
ymesika:cherryPick
Jan 31, 2019
Merged

Cherry Pick: Only add localhost IP if no other IP address were found (#11367)#11370
istio-testing merged 1 commit intoistio:masterfrom
ymesika:cherryPick

Conversation

@ymesika
Copy link
Copy Markdown
Member

@ymesika ymesika commented Jan 29, 2019

No description provided.

@ymesika
Copy link
Copy Markdown
Member Author

ymesika commented Jan 31, 2019

cc @wenchenglu

@wenchenglu
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wenchenglu, ymesika

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

@ymesika: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-integ-k8s-tests.sh 915fa40 link /test istio-integ-k8s-tests
prow/istio-pilot-multicluster-e2e.sh 915fa40 link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit e1aac14 into istio:master Jan 31, 2019
@ymesika ymesika deleted the cherryPick branch January 31, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants