Skip to content

Speculative fix for circleci build failures#10935

Closed
sdake wants to merge 1 commit intoistio:release-1.1from
sdake:speculative_go_1_11
Closed

Speculative fix for circleci build failures#10935
sdake wants to merge 1 commit intoistio:release-1.1from
sdake:speculative_go_1_11

Conversation

@sdake
Copy link
Copy Markdown
Member

@sdake sdake commented Jan 14, 2019

stackdriver is failing to build.

Speculative fix for circleci build failures
fa1597a 
stackdriver is failing to build.
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 14, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdake sdake mentioned this pull request Jan 14, 2019
Merged
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 14, 2019

@sdake: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e_pilotv2_auth_sds.sh fa1597a link /test istio_auth_sds_e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake sdake closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm

@rshriram rshriram Awaiting requested review from rshriram

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdake @istio-testing @googlebot