Skip to content

update envoy go-control-plane#10737

Merged
istio-testing merged 6 commits intoistio:release-1.1from
GregHanson:update-envoy2
Jan 8, 2019
Merged

update envoy go-control-plane#10737
istio-testing merged 6 commits intoistio:release-1.1from
GregHanson:update-envoy2

Conversation

@GregHanson
Copy link
Copy Markdown
Member

@GregHanson GregHanson commented Jan 4, 2019

No description provided.

@GregHanson GregHanson requested a review from rshriram January 4, 2019 13:40
@istio-testing istio-testing requested a review from linsun January 4, 2019 13:40
@GregHanson GregHanson mentioned this pull request Jan 4, 2019
Closed
rshriram
rshriram approved these changes Jan 4, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GregHanson, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson GregHanson mentioned this pull request Jan 7, 2019
Closed
@quanjielin
Copy link
Copy Markdown
Contributor

quanjielin commented Jan 7, 2019

for the failed unit test rbac_permissive_global and rbac_permissive_policy , seems it's because envoy rename attr shadow_response_code to shadow_engine_result recently; could you pls try to update attribute name in the test to see if it pass ?

@GregHanson
Copy link
Copy Markdown
Member Author

GregHanson commented Jan 7, 2019

rbac_permissive_policy_test.go: actual results:

        , Attributes: ---
        connection.mtls               : false
        context.protocol              : http
        context.proxy_error_code      : -
        context.reporter.uid          : 
        destination.namespace         : 
        destination.uid               : 
        envoy.filters.http.rbac       : stringmap[shadow_engine_result:allowed shadow_effective_policy_id:details-reviews-viewer]
        mesh1.ip                      : [1 1 1 1]
        mesh2.ip                      : [0 0 0 0 0 0 0 0 0 0 255 255 204 152 189 116]
        mesh3.ip                      : [0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 8]
        origin.ip                     : [127 0 0 1]
        request.headers               : stringmap[accept-encoding:gzip :authority:localhost:20245 :method:GET :path:/echo x-forwarded-proto:http x-request-id:95e69e9a-23a0-4a06-81d6-646a68c10bcb user-agent:Go-http-client/1.1 content-length:0]
        request.host                  : localhost:20245
        request.method                : GET
        request.path                  : /echo
        request.scheme                : http
        request.size                  : 0
        request.time                  : 2019-01-07 20:08:57.249132498 +0000 UTC
        request.total_size            : 0
        request.url_path              : /echo
        request.useragent             : Go-http-client/1.1
        response.code                 : 403
        response.duration             : 218.743µs
        response.headers              : stringmap[content-type:text/plain :status:403 date:Mon, 07 Jan 2019 20:08:57 GMT content-length:19 server:envoy]
        response.size                 : 19
        response.time                 : 2019-01-07 20:08:57.249169933 +0000 UTC
        response.total_size           : 111
        source.namespace              : XYZ11
        source.uid                    : POD11
        target.name                   : target-name
        target.namespace              : XYZ222
        target.uid                    : POD222
        target.user                   : target-user

@GregHanson
Copy link
Copy Markdown
Member Author

GregHanson commented Jan 7, 2019

acutal results from rbac_permissive_global_test.go

        , Attributes: ---
        check.cache_hit               : false
        connection.mtls               : false
        context.protocol              : http
        context.proxy_error_code      : -
        context.reporter.uid          : 
        destination.ip                : [127 0 0 1]
        destination.namespace         : 
        destination.port              : 20243
        destination.uid               : 
        envoy.filters.http.rbac       : stringmap[shadow_engine_result:denied]
        mesh1.ip                      : [1 1 1 1]
        mesh2.ip                      : [0 0 0 0 0 0 0 0 0 0 255 255 204 152 189 116]
        mesh3.ip                      : [0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 8]
        origin.ip                     : [127 0 0 1]
        quota.cache_hit               : false
        request.headers               : stringmap[x-request-id:46392670-b44f-48e6-80a3-a050e26fea06 user-agent:Go-http-client/1.1 content-length:0 accept-encoding:gzip :authority:localhost:20238 :method:GET :path:/echo x-forwarded-proto:http]
        request.host                  : localhost:20238
        request.method                : GET
        request.path                  : /echo
        request.scheme                : http
        request.size                  : 0
        request.time                  : 2019-01-07 20:14:42.319410385 +0000 UTC
        request.total_size            : 306
        request.url_path              : /echo
        request.useragent             : Go-http-client/1.1
        response.code                 : 200
        response.duration             : 7.413512ms
        response.headers              : stringmap[date:Mon, 07 Jan 2019 20:14:42 GMT x-envoy-upstream-service-time:1 content-length:0 server:envoy :status:200]
        response.size                 : 0
        response.time                 : 2019-01-07 20:14:42.326779199 +0000 UTC
        response.total_size           : 99
        source.namespace              : XYZ11
        source.uid                    : POD11
        target.name                   : target-name
        target.namespace              : XYZ222
        target.uid                    : POD222
        target.user                   : target-user

@GregHanson
Copy link
Copy Markdown
Member Author

GregHanson commented Jan 7, 2019

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Jan 7, 2019
@GregHanson
Copy link
Copy Markdown
Member Author

GregHanson commented Jan 7, 2019

@kyessenov open an issue for istio? or an issue in envoy?

@kyessenov
Copy link
Copy Markdown
Contributor

kyessenov commented Jan 7, 2019 via email

@GregHanson
Copy link
Copy Markdown
Member Author

GregHanson commented Jan 7, 2019

/test istio-unit-tests

@GregHanson GregHanson mentioned this pull request Jan 7, 2019
Closed
@quanjielin quanjielin mentioned this pull request Jan 7, 2019
Merged
@quanjielin
Copy link
Copy Markdown
Contributor

quanjielin commented Jan 7, 2019

hold label is fine to remove as all test pass ?

@quanjielin quanjielin removed the do-not-merge/hold Block automatic merging of a PR. label Jan 7, 2019
@istio-testing istio-testing merged commit a8dfd09 into istio:release-1.1 Jan 8, 2019
@GregHanson GregHanson deleted the update-envoy2 branch January 10, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linsun linsun Awaiting requested review from linsun

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rshriram rshriram

Labels

area/networking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GregHanson @istio-testing @quanjielin @kyessenov @rshriram @googlebot