Skip to content

Remove hardcoded sidecar template for istioctl kube-inject#10690

Closed
mathspanda wants to merge 1 commit intoistio:masterfrom
mathspanda:rm-inject-hc
Closed

Remove hardcoded sidecar template for istioctl kube-inject#10690
mathspanda wants to merge 1 commit intoistio:masterfrom
mathspanda:rm-inject-hc

Conversation

@mathspanda
Copy link
Copy Markdown
Contributor

@mathspanda mathspanda commented Dec 29, 2018

Fix issue #10380

  1. Remove hardcoded sidecar template in kube-inject.
  2. Modify some tests to read sidecar template from install/kubernetes/helm.
  3. Remove some meaningless tests for injecting.

Signed-off-by: mathspanda mathspanda826@gmail.com

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 29, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mathspanda
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai

If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 29, 2018

Hi @mathspanda. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

golangcibot
golangcibot reviewed Dec 29, 2018
View reviewed changes
@mathspanda mathspanda force-pushed the rm-inject-hc branch 4 times, most recently from f1b76c9 to 4e5c595 Compare December 29, 2018 07:33
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 31, 2018

@mathspanda: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mathspanda
Copy link
Copy Markdown
Contributor Author

mathspanda commented Jan 2, 2019

/assign @incfly

@incfly
Copy link
Copy Markdown

incfly commented Jan 2, 2019

Thanks for this work!

I'm currently out of office till 1/9. @mandarjog, @nmittler maybe you can provide some initial feedback?

@linsun
Copy link
Copy Markdown
Member

linsun commented Jan 3, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 3, 2019
@mathspanda
Remove hardcoded sidecar template for istioctl kube-inject
6a4734d 
1. remove hardcoded sidecar template
2. modify some tests to read sidecar template from install/kubernetes/helm
3. remove some meaningless tests for injecting

Signed-off-by: mathspanda <mathspanda826@gmail.com>
@mathspanda
Copy link
Copy Markdown
Contributor Author

mathspanda commented Jan 9, 2019 •
edited
Loading

The merge branch is wrong. Will submit another PR. Just close it.

@mathspanda mathspanda closed this Jan 9, 2019
@mathspanda mathspanda mentioned this pull request Jan 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esnible esnible Awaiting requested review from esnible

@geeknoid geeknoid Awaiting requested review from geeknoid

@kyessenov kyessenov Awaiting requested review from kyessenov

1 more reviewer

@golangcibot golangcibot golangcibot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@incfly incfly

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mathspanda @istio-testing @incfly @linsun @golangcibot @googlebot