Hi @itaysk. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Can you pleasse re-open it with release-1.1 as the target branch?

Codecov Report

Merging #10119 into master will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #10119    +/-   ##
========================================
- Coverage      70%      70%   -<1%     
========================================
  Files         436      436            
  Lines       41149    40899   -250     
========================================
- Hits        28735    28439   -296     
- Misses      11018    11084    +66     
+ Partials     1396     1376    -20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce4554...71e1aaa. Read the comment docs.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itaysk
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun

If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@itaysk: PR needs rebase.

@itaysk: The following tests failed, say /retest to rerun them all:

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@ymesika I changed the base to release-1.1
not sure what's the problem with CLA, I've contributed before to Istio with this account

CLAs look good, thanks!

@itaysk Yeah, we usually get those kind of errors when just switching branch.
I usually close and open new one but it seems fine now except that needs-rebase label.

not sure why it needs rebase, the prev commit is cdeb2771969ce3baff9d60bfc0cd315282015f81 which is the tip of release-1.1. If you think it's better to open a new PR I don't mind

closing this so I can open a new one for release-1.1