-
updateVersion.sh -c doesn't work
-
updateVersion.sh has been moved out of the tests directory, but tests/README.md is still the doc for it.
-
The generated comment in istio.INSTALL also refers to tests/updateVersion.sh and tests/README.md
PR #209 fixes these problems, and also simplifies the design to remove the files in install/kubernetes/templates and instead just update istio.yaml and istio-auth.yaml in place. This is a necessary simplification IMO, since the current design is very confusing. When you call updateVersion.sh, it not only updates the expected files (istio.VERSION, istio.yaml, and istio-auth.yaml) but it also updates 8 other template files, so the resulting git commit has 10 updated files. The fact that there are 10, instead of just 2 yaml files in the install directory is also confusing. The small benefit of not needing to make the same update to 2 files when there are non-image changes, which is fairly rare, is not worth the complexity.
If, however, we don't want to merge #209 before alpha, the above 3 problems need to be fixed in the current version.
updateVersion.sh -cdoesn't workupdateVersion.shhas been moved out of thetestsdirectory, buttests/README.mdis still the doc for it.The generated comment in
istio.INSTALLalso refers totests/updateVersion.shandtests/README.mdPR #209 fixes these problems, and also simplifies the design to remove the files in
install/kubernetes/templatesand instead just update istio.yaml and istio-auth.yaml in place. This is a necessary simplification IMO, since the current design is very confusing. When you call updateVersion.sh, it not only updates the expected files (istio.VERSION, istio.yaml, and istio-auth.yaml) but it also updates 8 other template files, so the resulting git commit has 10 updated files. The fact that there are 10, instead of just 2 yaml files in the install directory is also confusing. The small benefit of not needing to make the same update to 2 files when there are non-image changes, which is fairly rare, is not worth the complexity.If, however, we don't want to merge #209 before alpha, the above 3 problems need to be fixed in the current version.