Skip to content

pilot-agent processes Envoy bootstrap template passed via templateFile differently than the default one #11198

@alexburnos

Description

@alexburnos

Describe the bug
When templateFile is provided to the pilot-agent, it does some processing and writes out a custom config file for Envoy (

err = ioutil.WriteFile(proxyConfig.CustomConfigFile, content, 0644)
).

This effectively stops further processing of the template by bootstrap_config module and customConfigFile is being treated "as is". Which is inconsistent with how standard default envoy bootstrap template is being processed.

Expected behavior
Envoy bootstrap templateFile passed as an argument to pilot-agent should be handled exactly the same as default bootstrap template, effectively substituting the default template.

Steps to reproduce the bug
Pass default Envoy boostrap template as an argument of --templateFile to see that substitution of many parameters will not happen and resulting Envoy config will be stored under different name than config generated from the default template (/etc/istio/proxy/envoy.yaml vs /etc/proxy/proxy/envoy-rev0.yaml)

Version
Istio current / 1.0.5

Installation
Via helm

Environment
GCP

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions