This repository was archived by the owner on May 8, 2023. It is now read-only.
Merged
Conversation
To avoid package istio.io/fortio/vendor/golang.org/x/net/context: istio.io/fortio is a custom import path for https://github.com/istio/fortio, but /go/src/istio.io/fortio/vendor is checked out from https://github.com/istio-releases/fortio-vendor.git But then one gets golang/go#17522 (comment)
ldemailly
commented
Feb 11, 2018
| <html><head> | ||
| <meta name="go-import" content="istio.io/istio git https://github.com/istio/istio"> | ||
| <meta name="go-source" content="istio.io/istio https://github.com/istio/istio https://github.com/istio/istio/tree/master{/dir} https://github.com/istio/istio/blob/master{/dir}/{file}#L{line}"> | ||
| <meta name="go-import" content="istio.io/istio/vendor git https://github.com/istio-releases/vendor"> |
Contributor
There was a problem hiding this comment.
Would we switch to github.com/istio/vendor at some point once commited vendor dependency scheme is vetted?
Member
Author
There was a problem hiding this comment.
yes I think we could move istio-releases/vendor -> istio/vendor-istio and istio-releases/fortio-vendor -> istio/vendor-fortio
ayj
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid
But then one gets
golang/go#17522 (comment)