Skip to content

[Release-1.8] log: Add "%_" to print message with escaped newlines (#13832)#288

Merged
istio-testing merged 1 commit intoistio:release-1.8from
gargnupur:nup_ch_1.8
Dec 11, 2020
Merged

[Release-1.8] log: Add "%_" to print message with escaped newlines (#13832)#288
istio-testing merged 1 commit intoistio:release-1.8from
gargnupur:nup_ch_1.8

Conversation

@gargnupur
Copy link
Copy Markdown

This patch adds a new custom flag %_ to the log pattern to print the
actual message to log, but with escaped newlines.

Signed-off-by: Dhi Aurrahman dio@tetrate.io

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

This patch adds a new custom flag `%_` to the log pattern to print the
actual message to log, but with escaped newlines.

Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
@google-cla
Copy link
Copy Markdown

google-cla bot commented Dec 10, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.


New Features
------------
* config: added new runtime feature `envoy.features.enable_all_deprecated_features` that allows the use of all deprecated features.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why so many features are included?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, cherry-pick probably updated this file..

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a clean cherry-pick? The original pr is not adding so many text about features.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah there was not even a single conflict

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove the other lines if you want...

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is exactly the same so I assume it is ok.

@istio-testing istio-testing merged commit c658523 into istio:release-1.8 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants