listener: add match all filter chain (#13449)#276
Merged
istio-testing merged 1 commit intoistio:release-1.8from Oct 16, 2020
Merged
listener: add match all filter chain (#13449)#276istio-testing merged 1 commit intoistio:release-1.8from
istio-testing merged 1 commit intoistio:release-1.8from
Conversation
The match all filter chain is chosen when no other filter chain matches the request. Signed-off-by: Yuchen Dai <silentdai@gmail.com>
PiotrSikora
approved these changes
Oct 16, 2020
PiotrSikora
left a comment
There was a problem hiding this comment.
This is going to be a mess when backporting security fixes.
Author
Filter chain add() and find() are very independent. If filter chain manager is not the core of security, it's very unlikely affected by other components. I am a regretful on the unnecessary code clean up... not big though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from envoy 1.17-dev
The match all filter chain is chosen when no other filter chain matches
the request.
Signed-off-by: Yuchen Dai silentdai@gmail.com
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]