Skip to content

Create api/wasm/cpp/Makefile.base and use for WASM c++ compiles.#27

Merged
jplevyak merged 1 commit intoistio:wasmfrom
jplevyak:wasm-makefile
Feb 21, 2019
Merged

Create api/wasm/cpp/Makefile.base and use for WASM c++ compiles.#27
jplevyak merged 1 commit intoistio:wasmfrom
jplevyak:wasm-makefile

Conversation

@jplevyak
Copy link
Copy Markdown

Create api/wasm/cpp/Makefile.base and use for WASM c++ compiles.

@jplevyak jplevyak requested a review from PiotrSikora February 21, 2019 02:00
@istio-testing
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm, thanks!

@jplevyak jplevyak merged commit 4bb6c45 into istio:wasm Feb 21, 2019
@jplevyak jplevyak deleted the wasm-makefile branch February 21, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants