tls: improve wildcard matching (#11921) (#11927)#231
Merged
istio-testing merged 1 commit intoistio:release-1.4from Jul 8, 2020
Merged
tls: improve wildcard matching (#11921) (#11927)#231istio-testing merged 1 commit intoistio:release-1.4from
istio-testing merged 1 commit intoistio:release-1.4from
Conversation
Patching in 11885 with runtime guards and release notes Risk Level: Medium (changes to cert matching) Testing: new unit test Docs Changes: n/a Release Notes: inline Runtime guard: envoy.reloadable_features.fix_wildcard_matching Signed-off-by: Yann Soubeyrand <yann.soubeyrand@camptocamp.com> Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora
approved these changes
Jul 7, 2020
| * listener: add runtime support for `per-listener limits <config_listeners_runtime>` on active/accepted connections. | ||
| * overload management: add runtime support for :ref:`global limits <config_overload_manager>` on active/accepted connections. | ||
| 1.12.6 (July 7, 2020) | ||
| ===================== |
There was a problem hiding this comment.
This file is such a mess due to merge=union rule merging conflicts. Could you clean it up (just replace with whatever is in my branch or upstream)? It doesn't matter too much, so feel free to ignore it.
Author
There was a problem hiding this comment.
yes, i'll do that for all the PRs
Author
There was a problem hiding this comment.
lame, sorry, github merged it before I could update the branch. want a separate PR to update this file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patching in 11885 with runtime guards and release notes
Risk Level: Medium (changes to cert matching)
Testing: new unit test
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.fix_wildcard_matching
Signed-off-by: Yann Soubeyrand yann.soubeyrand@camptocamp.com
Signed-off-by: Alyssa Wilk alyssar@chromium.org
Signed-off-by: Piotr Sikora piotrsikora@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]