[release-1.6] manual cherry-pick of https://github.com/envoyproxy/env…#195
Merged
howardjohn merged 1 commit intomasterfrom Apr 17, 2020
Merged
[release-1.6] manual cherry-pick of https://github.com/envoyproxy/env…#195howardjohn merged 1 commit intomasterfrom
howardjohn merged 1 commit intomasterfrom
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Author
|
@howardjohn can you use superpowers to merge this? It's a cherry-pick. |
Member
|
Why are we cherrypicking to master instead of just syncing up to head of envoy? |
Author
|
Envoy head and envoy-wasm diverged. Wasm changes do not automatically get merged. |
Author
|
See previous discussion. proxy-wasm is a breaking change in envoy-wasm and we chose to use pre-proxy-wasm for 1.6. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oy-wasm/pull/482
Signed-off-by: Kuat Yessenov kuat@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]