Skip to content

Fixes ASSERT failure and infinite loop when attempting to unset readDisable state on a closed connection#190

Merged
istio-testing merged 1 commit intoistio:release-1.4from
dmitri-d:fix-infinite-loop
Mar 26, 2020
Merged

Fixes ASSERT failure and infinite loop when attempting to unset readDisable state on a closed connection#190
istio-testing merged 1 commit intoistio:release-1.4from
dmitri-d:fix-infinite-loop

Conversation

@dmitri-d
Copy link
Copy Markdown

@dmitri-d dmitri-d commented Mar 25, 2020

Port of envoyproxy#9509

ping @lambdai

@googlebot
Copy link
Copy Markdown

googlebot commented Mar 25, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Copy Markdown

googlebot commented Mar 25, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@lambdai
Copy link
Copy Markdown

lambdai commented Mar 25, 2020

@dmitri-d Thanks for the backport!
The commit LGTM
The only thing is that the branch is not the best place
CC release manager @jwendell @howardjohn

@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Mar 25, 2020

It should go to release-1.4 branch

And I guess also release-1.5?

@howardjohn howardjohn changed the base branch from release-1.4.6-patch to release-1.4 March 25, 2020 22:06
@howardjohn
Copy link
Copy Markdown
Member

howardjohn commented Mar 25, 2020

Wow I can change it myself. nice

lambdai
lambdai approved these changes Mar 25, 2020
View reviewed changes
Copy link
Copy Markdown

@lambdai lambdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the instant fix!

Fixes ASSERT failure and infinite loop when attempting to unset readD…
101b23f 
…isable state on a closed connection

This is a port of envoyproxy#9509

Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
@dmitri-d
Copy link
Copy Markdown
Author

dmitri-d commented Mar 26, 2020

  • fixed test failure

@dmitri-d
Copy link
Copy Markdown
Author

dmitri-d commented Mar 26, 2020

1.5 branch doesn't need this port -- the fix is there already (9de6027).

@istio-testing istio-testing merged commit 2776a8e into istio:release-1.4 Mar 26, 2020
@dmitri-d dmitri-d deleted the fix-infinite-loop branch March 26, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lambdai lambdai lambdai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmitri-d @googlebot @lambdai @howardjohn @istio-testing