[Release-1.5] Use ClusterInfo from streaminfo to get clustername too#189
Merged
istio-testing merged 1 commit intoistio:release-1.5from Mar 21, 2020
Merged
[Release-1.5] Use ClusterInfo from streaminfo to get clustername too#189istio-testing merged 1 commit intoistio:release-1.5from
istio-testing merged 1 commit intoistio:release-1.5from
Conversation
Signed-off-by: gargnupur <gargnupur@google.com> Remove files Signed-off-by: gargnupur <gargnupur@google.com>
kyessenov
reviewed
Mar 20, 2020
| return CelValue::CreateString(&info->upstreamHost()->cluster().name()); | ||
| } else if (info && info->routeEntry()) { | ||
| return CelValue::CreateString(&info->routeEntry()->clusterName()); | ||
| } else if (info && info->upstreamClusterInfo().has_value() && |
There was a problem hiding this comment.
Maybe make this the first clause since it's going to become the main way?
Author
There was a problem hiding this comment.
For 1.6? don't want to add a new thing as main way to 1.5?
kyessenov
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gargnupur gargnupur@google.com
Remove files
Signed-off-by: gargnupur gargnupur@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]