wasm: Add API to get buffered body data. (#437)#177
Merged
istio-testing merged 1 commit intoistio:release-1.5from Mar 4, 2020
Merged
wasm: Add API to get buffered body data. (#437)#177istio-testing merged 1 commit intoistio:release-1.5from
istio-testing merged 1 commit intoistio:release-1.5from
Conversation
6eda65a to
6c071fa
Compare
Now, if a callback previously returned StopIterationAndBuffer, the various "getBuffer" methods will return the buffered data. But if the callback previously returned anything else, then the methods will only return the current chunk. Signed-off-by: Gregory Brail <gregbrail@google.com> Signed-off-by: Piotr Sikora <piotrsikora@google.com>
6c071fa to
45fdef3
Compare
fpesce
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, if a callback previously returned StopIterationAndBuffer,
the various "getBuffer" methods will return the buffered data.
But if the callback previously returned anything else, then
the methods will only return the current chunk.
Signed-off-by: Gregory Brail gregbrail@google.com
Signed-off-by: Piotr Sikora piotrsikora@google.com