Skip to content

Sidecar Capture mode NONE to use Bind API changes#898

Merged
rshriram merged 1 commit intoistio:release-1.1from
shakti-das:shakti/sidecar-ip-bind
Apr 12, 2019
Merged

Sidecar Capture mode NONE to use Bind API changes#898
rshriram merged 1 commit intoistio:release-1.1from
shakti-das:shakti/sidecar-ip-bind

Conversation

@shakti-das
Copy link
Copy Markdown
Member

@shakti-das shakti-das commented Apr 11, 2019

Signed-off-by: Shakti shaktiprakash.das@salesforce.com

API doc changes for Istio issue istio/istio#13201

@shakti-das
Capture mode NONE to use Bind API changes
0285d42 
Signed-off-by: Shakti <shaktiprakash.das@salesforce.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 11, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shakti-das
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu

If they are not already assigned, you can assign the PR to them by writing /assign @frankbu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 11, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 11, 2019

Hi @shakti-das. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shakti-das shakti-das changed the title Capture mode NONE to use Bind API changes Sidecar Capture mode NONE to use Bind API changes Apr 11, 2019
@shakti-das shakti-das mentioned this pull request Apr 11, 2019
Merged
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Apr 11, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Apr 11, 2019
@rshriram rshriram merged commit 2252ef0 into istio:release-1.1 Apr 12, 2019
@shakti-das shakti-das deleted the shakti/sidecar-ip-bind branch April 12, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andraxylia andraxylia Awaiting requested review from andraxylia

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shakti-das @istio-testing @rshriram @googlebot