Skip to content

Add options for Datadog tracing in proxy config#797

Merged
istio-testing merged 1 commit intoistio:masterfrom
DataDog:cgilmour/datadog-tracer
Feb 18, 2019
Merged

Add options for Datadog tracing in proxy config#797
istio-testing merged 1 commit intoistio:masterfrom
DataDog:cgilmour/datadog-tracer

Conversation

@cgilmour
Copy link
Copy Markdown
Contributor

This PR adds Datadog as an option for the tracer used within istio.

This relates to istio/istio#6314 and is part of multiple PRs to completely deliver this.
The other parts are developed and tested internally, but depend on api changes before they can be finalized and submitted.

If this should target the release-1.1 branch instead, let me know and I'll sort things out.

Signed-off-by: Caleb Gilmour <caleb.gilmour@datadoghq.com>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 13, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @cgilmour. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@duderino
Copy link
Copy Markdown

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 15, 2019
Copy link
Copy Markdown
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rshriram
Copy link
Copy Markdown
Member

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgilmour, douglas-reid, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit f6b6c41 into istio:master Feb 18, 2019
@cgilmour cgilmour deleted the cgilmour/datadog-tracer branch February 19, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants