remove deprecated from OutboundTrafficPolicy. REGISTRY_ONLY and ALLOW_ALL#744
Conversation
mesh/v1alpha1/config.proto
Outdated
| // Services/Service Entries exist. In particular, it will allow traffic | ||
| // to any external service for which no internal/external Service/ | ||
| // Service Entry exist. | ||
| bool allow_traffic_to_unknown_ports = 31; |
There was a problem hiding this comment.
I am fine with this option (I know I suggested this :) ). That said, I also realized we have something similar and unused currently (
api/mesh/v1alpha1/config.proto
Line 152 in d1d3a02
There was a problem hiding this comment.
Sounds good, let me do it.
|
@rshriram How about this change, note the changed comment. Could you please approve it again? |
|
/approve I wonder if this wouldn't be the right place to add "REGISTRY_NAMESPACE_ONLY" - like REGISTRY, but restricted to settings in same namespace. Long term I expect people will switch to namespace only and the new Sidecar - which should allow '*' ( == allow all). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: costinm, vadimeisenbergibm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Per discussion with @louiscryan , we decided to not do any global flag for the sidecar resource. People have to specify the resource for each namespace. |
related to istio/istio#10330