Hi @shakti-das. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Comments from previous PR for master:

to release-1.1 branch
The issue asks for Mesh level configuration while what you are doing here is at DestinationRule level
Granted that you can define a Global DestinationRule, but it will get overwritten when someone declares something local. Does it make sense to move this to mesh/config.proto (its a bit of a kitchen sink right now). I don't mind having this in the DestinationRule (in fact we should have it there in addition to mesh config I guess).

This PR adds tcp_keepalive settings in DestinationRule and MeshConfig. The assignment logic would be as follows:
DestinationRule (if set, else next) > MeshConfig (if set, else next) > OS default (skip the envoy config)

Skipped keepalive probes and only kept keepalive time and interval for now. OS default probes will be sent.

@hzxuzhonghu pointed out in the other thread that probes is also part of requirement. So, adding probes as per istio/istio#9378 (comment).

I was thinking with these 3 items added, the message is similar to the one used in envoy proto. Does istio ever use imported protos from envoy? Code search doesn't show any prior art where envoy messages are reused in istio though, maybe to avoid dependency issues?

@rshriram The review comments from PR #715 are implemented here. Please review.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rshriram, shakti-das

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/ok-to-test