Skip to content

update comment#695

Merged
istio-testing merged 1 commit intoistio:release-1.1from
hzxuzhonghu:fs-MCp
Nov 5, 2018
Merged

update comment#695
istio-testing merged 1 commit intoistio:release-1.1from
hzxuzhonghu:fs-MCp

Conversation

@hzxuzhonghu
Copy link
Copy Markdown
Member

use fs:/// to indicate a file directory instead of file:/// which may confuse users.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 5, 2018
@hzxuzhonghu
Copy link
Copy Markdown
Member Author

/assign @rshriram

Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 510451b into istio:release-1.1 Nov 5, 2018
@hzxuzhonghu hzxuzhonghu deleted the fs-MCp branch November 6, 2018 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants