Skip to content

Fix style for TLS enum in networking.#690

Merged
rshriram merged 2 commits intoistio:release-1.1from
jeffmendoza:fix-tls-style-11
Nov 1, 2018
Merged

Fix style for TLS enum in networking.#690
rshriram merged 2 commits intoistio:release-1.1from
jeffmendoza:fix-tls-style-11

Conversation

@jeffmendoza
Copy link
Copy Markdown
Contributor

@jeffmendoza jeffmendoza commented Nov 1, 2018

I don't think this requires any change in Istio code. This is mapped to:
https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/auth/cert.proto

The code here: https://github.com/istio/istio/blob/release-1.1/pilot/pkg/networking/core/v1alpha3/gateway.go#L435 is copying it over, but only referencing the envoy proto.

Let's get this into 1.1 before it ships.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Nov 1, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm

If they are not already assigned, you can assign the PR to them by writing /assign @costinm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 1, 2018
@jeffmendoza
Copy link
Copy Markdown
Contributor Author

jeffmendoza commented Nov 1, 2018

Fixes #688 cc @costinm @rshriram @ijsnellf

@costinm
Copy link
Copy Markdown
Contributor

costinm commented Nov 1, 2018

Was this added after 1.0.x ? If not - need to test if upgrade works. I suspect this is safe, but not sure.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Nov 1, 2018

This was added a couple of weeks ago.

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Nov 1, 2018

verified that it doesn't exist in 1.0.x

@rshriram rshriram merged commit 20d2d5d into istio:release-1.1 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hklai hklai Awaiting requested review from hklai

@mandarjog mandarjog Awaiting requested review from mandarjog

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffmendoza @istio-testing @costinm @rshriram @googlebot