Add HTTPRetry config to allow setting retryOn policy#679
Add HTTPRetry config to allow setting retryOn policy#679rshriram merged 1 commit intoistio:release-1.1from hzxuzhonghu:release-1.1
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| // The supported policies can be found in | ||
| // "https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-on" | ||
| // and "https://www.envoyproxy.io/docs/envoy/latest/configuration/http_filters/router_filter#x-envoy-retry-grpc-on" | ||
| string retryOn = 3; |
There was a problem hiding this comment.
Note: when you implement this in istio/istio, make sure to set the retry plugin as wel
retry_host_predicate:
- name: envoy.retry_host_predicates.previous_hosts
host_selection_retry_max_attempts: 3
along with other options from here. The above settings will prevent Envoy from selecting the same failed host (which is the default).
There was a problem hiding this comment.
Thanks for reminder, will do it. And learn more about envoy configuration.
|
@rshriram Is this need for master branch? so that I can update vendor in istio.io/istio. And implement this in it. |
istio/istio#8081