Skip to content

Cherry picked network config#667

Merged
rshriram merged 2 commits intoistio:release-1.1from
ymesika:cherryPick
Oct 21, 2018
Merged

Cherry picked network config#667
rshriram merged 2 commits intoistio:release-1.1from
ymesika:cherryPick

Conversation

@ymesika
Copy link
Copy Markdown
Member

@ymesika ymesika commented Oct 21, 2018

No description provided.

rshriram and others added 2 commits October 21, 2018 17:47
* clarity

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* renaming

* nits

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai

If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link
Copy Markdown
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Oct 21, 2018
@ymesika
Copy link
Copy Markdown
Member Author

ymesika commented Oct 21, 2018

/assign @rshriram

@rshriram rshriram merged commit 0ca0781 into istio:release-1.1 Oct 21, 2018
@ymesika ymesika deleted the cherryPick branch October 25, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants