Skip to content

update rbac api version to rbac.istio.io/v1alpha1.#588

Merged
rshriram merged 1 commit intoistio:release-1.0from
yangminzhu:update-rbac
Jul 19, 2018
Merged

update rbac api version to rbac.istio.io/v1alpha1.#588
rshriram merged 1 commit intoistio:release-1.0from
yangminzhu:update-rbac

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

align with istio/istio#6874

/cc @ymesika

@yangminzhu yangminzhu requested review from liminw and rshriram July 18, 2018 21:27
@istio-testing istio-testing requested a review from ymesika July 18, 2018 21:27
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 18, 2018
Copy link
Copy Markdown
Contributor

@liminw liminw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: liminw, yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu

Assign the PR to them by writing /assign @frankbu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit d5dc7af into istio:release-1.0 Jul 19, 2018
@yangminzhu yangminzhu deleted the update-rbac branch July 19, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants