Fix some proto descriptions#3384
Merged
istio-testing merged 4 commits intoistio:masterfrom Dec 12, 2024
Merged
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
Contributor
Author
|
/retest |
hzxuzhonghu
reviewed
Dec 11, 2024
hzxuzhonghu
reviewed
Dec 11, 2024
hzxuzhonghu
approved these changes
Dec 12, 2024
howardjohn
approved these changes
Dec 12, 2024
| // service originates from workloads in "us-west/zone1/*", 80% of the traffic | ||
| // will be sent to endpoints in "us-west/zone1/*", i.e the same zone, and the | ||
| // remaining 20% will go to endpoints in "us-west/zone2/*". This setup is | ||
| // Given a mesh with workloads and their service deployed to "us-west/zone1/\*" |
Member
There was a problem hiding this comment.
nit: code block may be preferred to the escape
Collaborator
|
In response to a cherrypick label: new pull request created: #3385 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of tidying up:
s/Pilot/istiod/codein some descriptionsGenerated files are using the old HTML generator at this point.