Skip to content

Commit 9fe6a7d

Browse files
howardjohnistio-testing
howardjohn
authored and
istio-testing
committed
Fix default doc for idle timeout (#1140)
This was changed in envoyproxy/envoy#8629
1 parent 9a5ec23 commit 9fe6a7d

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎networking/v1alpha3/destination_rule.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@
367367
"format": "int32"
368368
},
369369
"idleTimeout": {
370-
"description": "The idle timeout for upstream connection pool connections. The idle timeout is defined as the period in which there are no active requests. If not set, there is no idle timeout. When the idle timeout is reached the connection will be closed. Note that request based timeouts mean that HTTP/2 PINGs will not keep the connection alive. Applies to both HTTP1.1 and HTTP2 connections.",
370+
"description": "The idle timeout for upstream connection pool connections. The idle timeout is defined as the period in which there are no active requests. If not set, the default is 1 hour. When the idle timeout is reached the connection will be closed. Note that request based timeouts mean that HTTP/2 PINGs will not keep the connection alive. Applies to both HTTP1.1 and HTTP2 connections.",
371371
"type": "string"
372372
},
373373
"h2UpgradePolicy": {

‎networking/v1alpha3/destination_rule.pb.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎networking/v1alpha3/destination_rule.pb.html‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎networking/v1alpha3/destination_rule.proto‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ message ConnectionPoolSettings {
440440
int32 max_retries = 4;
441441

442442
// The idle timeout for upstream connection pool connections. The idle timeout is defined as the period in which there are no active requests.
443-
// If not set, there is no idle timeout. When the idle timeout is reached the connection will be closed.
443+
// If not set, the default is 1 hour. When the idle timeout is reached the connection will be closed.
444444
// Note that request based timeouts mean that HTTP/2 PINGs will not keep the connection alive. Applies to both HTTP1.1 and HTTP2 connections.
445445
google.protobuf.Duration idle_timeout = 5;
446446

0 commit comments

Comments
 (0)