Skip to content

Conversation

@pankajparkar
Copy link
Contributor

@pankajparkar pankajparkar commented Jun 16, 2018

I've added Jasmine Karma test cases for each feature of isteven-multiselect. I wrote somewhere around 50 test cases. Feel free to suggest / add specific case which I might have missed. Hoping to get positive reply soon 🤞🤞

I understand I'm late in the party, though I'm happy that I did something which could make this isteven-multiselect to be more maintainable. Whoever is going to modify anything in future either by submitting PR or their local modified version. They can run these test cases to make sure they haven't broken other features of this library.

@isteven isteven merged commit a6c9c8e into isteven:master Jun 17, 2018
@pankajparkar
Copy link
Contributor Author

@isteven Any plans to release the same to npm?

@pankajparkar pankajparkar deleted the unit-testcases branch June 22, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants