Conversation
Contributor
ncalteen
commented
Oct 20, 2025
- Added support for inferring version from C# project files (.csproj).
- Updated README to include C# as a supported language with its manifest file.
- Added valid and invalid C# project file examples for testing.
- Bumped package version to 2.6.0.
- Added support for inferring version from C# project files (.csproj). - Updated README to include C# as a supported language with its manifest file. - Added valid and invalid C# project file examples for testing. - Bumped package version to 2.6.0.
There was a problem hiding this comment.
Pull Request Overview
This PR adds C# project file support to the version inference system by implementing parsing logic for .csproj files. The implementation introduces an extension-based parser alongside the existing filename-based parser to handle manifest files that may have different names but share the same extension.
Key Changes:
- Implemented XML parsing for
.csprojfiles to extract version information fromProject.PropertyGroup.Version - Introduced
extensionParsermap to support extension-based manifest file parsing - Added comprehensive test coverage for both valid and invalid C# project files
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/version.ts |
Added extensionParser map with .csproj support and fallback logic to check extension-based parsers |
package.json |
Bumped version from 2.5.0 to 2.6.0 |
__tests__/version.test.ts |
Added test cases for valid and invalid C# project file version inference |
__fixtures__/valid/csharp/example.csproj |
Created valid C# project file fixture with version 1.2.3-alpha.4+build.5 |
__fixtures__/invalid/csharp/example.csproj |
Created invalid C# project file fixture without version property |
README.md |
Added C# with <project>.csproj to supported languages table |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.