Skip to content

Adding 6c lut and editing config for glint model#25

Merged
pgbrodrick merged 1 commit into
isofit:mainfrom
evan-greenbrg:tests/glint
Jul 10, 2025
Merged

Adding 6c lut and editing config for glint model#25
pgbrodrick merged 1 commit into
isofit:mainfrom
evan-greenbrg:tests/glint

Conversation

@evan-greenbrg

@evan-greenbrg evan-greenbrg commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

Files for examples test for glint model.

Companion PR on ISOFIT: isofit/isofit#727

@pgbrodrick

Copy link
Copy Markdown
Contributor

Thanks for this Evan! Traditionally we don't add the lut.nc files - we could (it's small), but it's probably a benefit for the model to reconstruct it every time on the fly. Is that rationale for including to abstract out the requirement for the 6c emulator while it's still developmental?

Everything else looks good to me!

@evan-greenbrg

Copy link
Copy Markdown
Collaborator Author

@pgbrodrick I included the .nc file because I actually wasn't sure if the actions had access to sRTMnet (or which version it had access to). Is it correct that the .sh, .inp, and 6s outputs are all 6s-related files and that without the .nc file, the sRTMnet predictions would have to still run?

If that is the case and I'm not completely wrong, I added the .nc assuming that we weren't planning on linking the development 6c emulator into the actions.

I can add/remove the .nc files as needed so any guidance w.r.t. consistency is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants