Skip to content

Forward model patch fixes#966

Merged
unbohn merged 2 commits into
isofit:devfrom
pgbrodrick:fm_refactor_patches
May 31, 2026
Merged

Forward model patch fixes#966
unbohn merged 2 commits into
isofit:devfrom
pgbrodrick:fm_refactor_patches

Conversation

@pgbrodrick

@pgbrodrick pgbrodrick commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Trying to resolve some discrepancies between 3.7.7 and 4.0.0-alpha. Currently, presolve solution give consistent RTMs, but different converged solutions. Fixes are:

  1. L_tot needs to not have eq_11 terms applied to it, or we double count
  2. the cache from reader.py was getting polluted from the get_L_coupled call, as the stored dictionary was mutable. To fix, the logic inside get_L_coupled was modified to create new variables during the inline multiplication, rather than write over.

@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
📊 Generated results:

URL: isofit/isofit-test-results#36
SHA: 7241698

@pgbrodrick

Copy link
Copy Markdown
Collaborator Author

This seems to resolve all issues I was seeing - full solutions match one to one:

Screenshot 2026-05-28 at 9 50 17 PM

@unbohn

unbohn commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Great! Thanks, @pgbrodrick. Merging.

@unbohn unbohn merged commit 3484d7e into isofit:dev May 31, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants