Skip to content

Starting merge RT and engines#947

Closed
evan-greenbrg wants to merge 5 commits into
isofit:rte_refactorfrom
evan-greenbrg:rte_refactor
Closed

Starting merge RT and engines#947
evan-greenbrg wants to merge 5 commits into
isofit:rte_refactorfrom
evan-greenbrg:rte_refactor

Conversation

@evan-greenbrg

Copy link
Copy Markdown
Collaborator

Definitely work in progress.

I've liberally used TODOs throughout for places where I expect things to significantly change.

A few things that popped out.

  1. Depending on how the LUT-engine abstraction played out much of the atmosphere.init may move
  2. If we want a generic LUT class, we can get rid of the big lut_exist block
  3. We'll need to go through each of the engines to make sure they reflect the new inheritance/config structure
  4. There are a couple of keys (e.g. multipart_transmittance) that may make more sense at the forward_model level

@evan-greenbrg

Copy link
Copy Markdown
Collaborator Author

Close in favor of #953. Had to re-open to accommodate the ability to rebase (messed up the rebase)

@evan-greenbrg evan-greenbrg deleted the rte_refactor branch May 22, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants