Small clean up of template construction#918
Merged
pgbrodrick merged 4 commits intoMar 31, 2026
Merged
Conversation
Collaborator
|
Thanks Brent! As discussed today, this looks great....mechanics all look solid too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very minor but we can leverage the modtran polynomials and completely remove
calc_modtran_max_water(). This allows formax_waterto be estimated for any RT engine. For background, a method similar to this was used to create the polynomials so we are saving ourselves a step by just using the stored data.I also removed ,
define_surface_types()- appears to be a classification method, but we already have similar code in the multicomponent_classification.py which uses theSurfaceMapping. Probably best to stick with this one.copy_file_subset()- unusedreassemble_cube()- unused