Advanced Testing Workflows#880
Merged
Merged
Conversation
65edf47 to
a0e14a9
Compare
…enbrg/isofit into workflows/advanced-testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new workflow that generates images and other results we may want off of test cases and posts them into a secondary repo. The workflow then comments back to the PR with a link to those results, which should open the door for us to do more advanced testing and raise our confidence in results.
Before accepting this PR, we need to ensure this is set in the settings:
With the way this workflow is developed, it risks malicious entities editing the workflow to steal the secret enabling write permission to the results repo. Given this repo won't be used for anything other than storing results, this likely isn't that big of a risk, but it's good practice to just disable workflows for external users until someone on the dev team approves workflow execution
[rebuild-cache]