Patch to lower sky glint sigma#868
Merged
Merged
Conversation
pgbrodrick
reviewed
Feb 16, 2026
pgbrodrick
left a comment
Collaborator
There was a problem hiding this comment.
This seems reasonable to me. Agreed that eventually, we may want hooks for these, but it depends on how much we end up adjusting them. @davidraythompson , does this look reasonable to you as well? If so, I think this is safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowering the sky glint variance in the surface prior improves solutions for certain water surfaces. Seen in cases with dark water, inland water, and foamy/whitecap water, the analytical solutions for sky glint blow up, and drive reflectance negative in the blue.
See "foamy" pixels in top right
With this patch fix:
TODO:
The non-rfl surface state-vector priors are set correctly in the config. We just need to add the hooks to be able to access these values easily via ApplyOE.