Modular config sections, LUTconfig kwargs#859
Merged
Conversation
cf61c69 to
212c266
Compare
Collaborator
|
This makes a lot of sense to me as a pathway to support additional flexibility. |
608ca2f to
a78fe14
Compare
dn file bugfix Missing h2o_lut_grid Missing rt args Adding hook for ray_ip_head
a78fe14 to
3bdaa1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
make_surface_config,make_rt_config,make_implementaiton_config). Externally, these are still wrapped in thebuild_configfunction. It's useful to be able to call the section-specific functions directly if the IO portion isn't needed (when constructing a config to set up a Inversion.invert call for example).pathsargument from these internal functions. Explictely refer to the paths used.kwargsin addition to the.jsonfile.