Adding surface files to isofit download#850
Merged
Merged
Conversation
Collaborator
|
Great addition. Thanks, @evan-greenbrg! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be advantageous to include the necessary surface files in the ISOFIT download step during setup. That way, we wouldn't have to point the user to an external (non-isofit) github repository for the suggested prior files. It seems like standard practice to point users to flavors of the EMIT-AVIRII surface files.
This PR would formalize the linkage by adding direct access to the emit-sds-l2a repo as a formal downloadable source.
This comes at a cost, however. More bloat within the downloader module and larger local storage requirements following the size of the spectral libraries.