Moving imagecube to examples/image_cube#849
Conversation
3.4.3 release
3.5.0 merge
3.5.1 release
3.6.0 release
jammont
left a comment
There was a problem hiding this comment.
Coupling the image cube data with the examples is a good idea to streamline the process.
We recently implemented isofit download examples --neon to download just the neon data. Would it be better to deprecate isofit download imagecube --size [small/medium] in favour of isofit download examples --imagecube [both/small/medium]? Less download commands, makes it clear imagecube is a part of examples
This would deprecate data/cli/imagecube.py and just move the downloader under examples too, which code consolidation is good
|
|
||
|
|
||
| def download_neon(examples): | ||
| def download_neon(examples, overwrite=False): |
There was a problem hiding this comment.
Good addition, be sure to add the parameter to:
download_cli:
download_neon(examples=Path(path), overwrite=kwargs["overwrite"])|
100% agree. Great idea @jammont to consolidate. I'll make that change. |
fe7160c to
4a74e38
Compare
|
Shifted to #855 because of bad merge-history |
Requires: isofit/isofit-tutorials#41