Surface component selection improvements#839
Merged
Merged
Conversation
Collaborator
Author
|
Look at alternatives to gaussian smoothing. |
Collaborator
|
Thanks for this improvement, @evan-greenbrg! I ran some local tests with the new SGA metric on EMIT snow scenes: no errors and good looking results. This should be ready for merge. |
unbohn
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Euclidean surface component selection does not accurately match surface types for many water surfaces. This PR is a limited attempt to improve the prior selection.
For a green open water pixel:
Using the EMIT prior libraries, the surface_liquids prior is selected:
With the same reference wavelengths, but using a spectral gradient angle:
Inland water remains challenging from a prior standpoint:
Is this background? Floating veg? Algae?
Changes:
selection_metricwithinsurface.json. A couple of ways to do this. I chose not to add another Apply OE hook. Instead, I put this in the surface config. However, to make this backward compatible the existing strategy of default filling the config object fromconfigs.pyis still in there for now.